[PATCH 2/4] ch: Demote error when CH driver fails to init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



If the host doesn't have /dev/kvm nor /dev/mshv, i.e. CH driver
is unable to run any guests, then an error is reported. But the
usual thing to do here is print an info message into the logs and
return VIR_DRV_STATE_INIT_SKIPPED. It is a recoverable error
after all.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 src/ch/ch_driver.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
index 2601eea44b..9394924f2d 100644
--- a/src/ch/ch_driver.c
+++ b/src/ch/ch_driver.c
@@ -893,9 +893,8 @@ static int chStateInitialize(bool privileged,
                                         VIR_ARCH_NONE, VIR_DOMAIN_VIRT_KVM) &&
         !virCapabilitiesDomainSupported(ch_driver->caps, -1,
                                         VIR_ARCH_NONE, VIR_DOMAIN_VIRT_HYPERV)) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("/dev/kvm and /dev/mshv are missing. CH driver failed to initialize."));
-        return VIR_DRV_STATE_INIT_ERROR;
+        VIR_INFO("/dev/kvm and /dev/mshv are missing. CH driver failed to initialize.");
+        return VIR_DRV_STATE_INIT_SKIPPED;
     }
 
     if (!(ch_driver->xmlopt = chDomainXMLConfInit(ch_driver)))
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux