[PATCH 1/5] qemu: Add missing early returns

[Andrea Bolognani <abologna@xxxxxxxxxx>]

In a couple of cases, we were reporting an error without
actually terminating the parse process.

Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
---
 src/qemu/qemu_firmware.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index d39e61d071..3fd4f75778 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -439,6 +439,7 @@ qemuFirmwareMappingKernelParse(const char *path,
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("missing 'filename' in '%1$s'"),
                        path);
+        return -1;
     }
 
     kernel->filename = g_strdup(filename);
@@ -458,6 +459,7 @@ qemuFirmwareMappingMemoryParse(const char *path,
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("missing 'filename' in '%1$s'"),
                        path);
+        return -1;
     }
 
     memory->filename = g_strdup(filename);
-- 
2.43.2
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx