[libvirt] [PATCH] virFileHasSuffix case sensitivity

[Paul Dorman <paul.dorman@xxxxxxxxx>]

Hi Eric,

sure. Here you go. Please let me know if there's anything else I need to do.

diff --git a/src/util/util.c b/src/util/util.c

index a7bb67c..3209185 100644

--- a/src/util/util.c

+++ b/src/util/util.c

@@ -1153,7 +1153,7 @@ int virFileHasSuffix(const char *str,

     if (len < suffixlen)

         return 0;

 

-    return STREQ(str + len - suffixlen, suffix);

+    return STRCASEEQ(str + len - suffixlen, suffix);

 }

 

 # define SAME_INODE(Stat_buf_1, Stat_buf_2) \

Regards,

Paul

On Thu, Apr 29, 2010 at 3:43 PM, Eric Blake <eblake@xxxxxxxxxx> wrote:

On 04/28/2010 09:24 PM, Paul Dorman wrote:
> Hi all,
>
> virFileHasSuffix fails on esx IDE fileName VMX entries that aren't lower
> case, e.g. '.ISO'. Unless there's a good reason, can the comparison be done
> with STRCASEEQ instead of STREQ?

Seems reasonable to me.  It would help if you could write a patch for
that, but if not, I can probably get around to figuring out the
appropriate patch based on your description.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list