Re: [PATCH 0/3] syntax-check: Sync with gnulib, some tweaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/16/24 15:47, Andrea Bolognani wrote:
> One might see patch 3/3 and think hey, it would actually be nice if
> developers were getting warned that some checks haven't been executed
> because a tool is missing! And I completely agree.
> 
> However, since meson needs to see an exit code of 77 to mark a test
> as skipped, and make return codes are in the range 0-2, making that
> happen would require taking the cppi/flake8/black checks out of the
> current scaffolding and wrap them in some other way. I have no
> intention to shave that specific yak today O:-)
> 
> Andrea Bolognani (3):
>   all: Don't use 'grep -q'
>   syntax-check: Sync with gnulib
>   syntax-check: Drop 'syntax-check' target
> 
>  build-aux/syntax-check.mk | 33 ++++++++-------------------------
>  libvirt.spec.in           |  2 +-
>  tests/virsh-uriprecedence |  2 +-
>  tests/virt-aa-helper-test |  2 +-
>  4 files changed, 11 insertions(+), 28 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux