Re: [libvirt] [PATCH] Fix a virsh edit memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/28/2010 02:27 PM, Chris Lalancette wrote:
> When running virsh edit, we are unlinking and setting
> the tmp variable to NULL before going to the end of the
> function, meaning that we never free tmp.  Since the
> exit to the function will always unlink and free tmp,
> just remove this bit of code and let it get done at the
> end.

ACK.  By the way, should we add another patch to warn if unlink() fails
for any reason?

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]