On Thu, Jan 25, 2024 at 03:50:33PM +0100, Peter Krempa wrote: > On Wed, Jan 24, 2024 at 20:37:45 +0100, Andrea Bolognani wrote: > > +static int > > IMO at this point you can return virDomainChrSerialTargetModel. Sure, I can try that. But what's the advantage? Ultimately we store most (all?) models as int inside structs, and only cast them to the proper enum type for switches. Which is a real shame, obviously, but IIRC was done for Some Actual Reason™. Or am I misremembering? -- Andrea Bolognani / Red Hat / Virtualization _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx