On Wed, Jan 24, 2024 at 20:37:26 +0100, Andrea Bolognani wrote: > We currently have a single test case called "minimal", which > suffers from two big flaws: > > * it's limited to the x86_64/pc machine type; > * it explicitly enables a number of devices. > > Add several test cases, one for each of the architectures and > machine types that we have good support for. > > Unlike the existing one, they're *really* minimal: no devices > or controllers at all are present in the input XML. So the new > test cases demonstrate exactly what devices and controller > libvirt will decide to add automatically. > > Note that we use the ABI_UPDATE variant of the test macros > because, in some cases, the behavior for new guests is not the > same as that for existing ones due to backward compatibility > concerns, and we specifically care about the former. IMO it would make sense to also add the non-ABI update cases. > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > .../aarch64-virt-minimal.aarch64-latest.args | 31 ++++++++++++ > .../aarch64-virt-minimal.aarch64-latest.xml | 26 ++++++++++ > .../qemuxmlconfdata/aarch64-virt-minimal.xml | 12 +++++ > .../ppc64-pseries-minimal.ppc64-latest.args | 33 ++++++++++++ > .../ppc64-pseries-minimal.ppc64-latest.xml | 33 ++++++++++++ > .../qemuxmlconfdata/ppc64-pseries-minimal.xml | 12 +++++ > .../riscv64-virt-minimal.riscv64-latest.args | 33 ++++++++++++ > .../riscv64-virt-minimal.riscv64-latest.xml | 33 ++++++++++++ > .../qemuxmlconfdata/riscv64-virt-minimal.xml | 12 +++++ > .../s390x-ccw-minimal.s390x-latest.args | 32 ++++++++++++ > .../s390x-ccw-minimal.s390x-latest.xml | 27 ++++++++++ > tests/qemuxmlconfdata/s390x-ccw-minimal.xml | 12 +++++ > .../x86_64-pc-minimal.x86_64-latest.args | 33 ++++++++++++ > .../x86_64-pc-minimal.x86_64-latest.xml | 31 ++++++++++++ > tests/qemuxmlconfdata/x86_64-pc-minimal.xml | 12 +++++ > .../x86_64-q35-minimal.x86_64-latest.args | 38 ++++++++++++++ > .../x86_64-q35-minimal.x86_64-latest.xml | 50 +++++++++++++++++++ > tests/qemuxmlconfdata/x86_64-q35-minimal.xml | 12 +++++ even if you decide to do the above, you can use Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> without reposting. _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
