Re: [PATCH 16/18] tests: Add *-default-devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 17, 2024 at 10:54:49 +0100, Andrea Bolognani wrote:
> This provides coverage for the set of devices that libvirt will
> automatically add to any new guest. They can vary quite a lot
> depending on the architecture.
> 
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  ...arch64-default-devices.aarch64-latest.args | 31 +++++++++++++++++
>  .../aarch64-default-devices.xml               | 12 +++++++
>  .../ppc64-default-devices.ppc64-latest.args   | 33 +++++++++++++++++++
>  .../ppc64-default-devices.xml                 | 12 +++++++
>  ...iscv64-default-devices.riscv64-latest.args | 33 +++++++++++++++++++
>  .../riscv64-default-devices.xml               | 12 +++++++
>  .../s390x-default-devices.s390x-latest.args   | 32 ++++++++++++++++++
>  .../s390x-default-devices.xml                 | 12 +++++++
>  .../x86_64-default-devices.x86_64-latest.args | 33 +++++++++++++++++++
>  .../x86_64-default-devices.xml                | 12 +++++++
>  tests/qemuxml2argvtest.c                      |  6 ++++
>  ...aarch64-default-devices.aarch64-latest.xml | 26 +++++++++++++++
>  .../ppc64-default-devices.ppc64-latest.xml    | 33 +++++++++++++++++++
>  ...riscv64-default-devices.riscv64-latest.xml | 33 +++++++++++++++++++
>  .../s390x-default-devices.s390x-latest.xml    | 27 +++++++++++++++
>  .../x86_64-default-devices.x86_64-latest.xml  | 31 +++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  6 ++++
>  17 files changed, 384 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/aarch64-default-devices.aarch64-latest.args
>  create mode 100644 tests/qemuxml2argvdata/aarch64-default-devices.xml
>  create mode 100644 tests/qemuxml2argvdata/ppc64-default-devices.ppc64-latest.args
>  create mode 100644 tests/qemuxml2argvdata/ppc64-default-devices.xml
>  create mode 100644 tests/qemuxml2argvdata/riscv64-default-devices.riscv64-latest.args
>  create mode 100644 tests/qemuxml2argvdata/riscv64-default-devices.xml
>  create mode 100644 tests/qemuxml2argvdata/s390x-default-devices.s390x-latest.args
>  create mode 100644 tests/qemuxml2argvdata/s390x-default-devices.xml
>  create mode 100644 tests/qemuxml2argvdata/x86_64-default-devices.x86_64-latest.args
>  create mode 100644 tests/qemuxml2argvdata/x86_64-default-devices.xml
>  create mode 100644 tests/qemuxml2xmloutdata/aarch64-default-devices.aarch64-latest.xml
>  create mode 100644 tests/qemuxml2xmloutdata/ppc64-default-devices.ppc64-latest.xml
>  create mode 100644 tests/qemuxml2xmloutdata/riscv64-default-devices.riscv64-latest.xml
>  create mode 100644 tests/qemuxml2xmloutdata/s390x-default-devices.s390x-latest.xml
>  create mode 100644 tests/qemuxml2xmloutdata/x86_64-default-devices.x86_64-latest.xml

[...]

> diff --git a/tests/qemuxml2argvdata/x86_64-default-devices.xml b/tests/qemuxml2argvdata/x86_64-default-devices.xml
> new file mode 100644
> index 0000000000..33cebaebd8
> --- /dev/null
> +++ b/tests/qemuxml2argvdata/x86_64-default-devices.xml
> @@ -0,0 +1,12 @@
> +<domain type='qemu'>
> +  <name>guest</name>
> +  <uuid>1ccfd97d-5eb4-478a-bbe6-88d254c16db7</uuid>
> +  <memory>4194304</memory>
> +  <vcpu>4</vcpu>
> +  <os>
> +    <type arch='x86_64' machine='pc'>hvm</type>

IMO it would make sense to have one for q35 too.

> +  </os>
> +  <devices>
> +    <emulator>/usr/bin/qemu-system-x86_64</emulator>
> +  </devices>
> +</domain>

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux