This series depends on the 'part 2' with cover letter's subject: [PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing both this along with the rebased prerequisite series can be fetched from: git fetch https://gitlab.com/pipo.sk/libvirt.git test-improvements-3 The main goal of part 3 is to add testing based on parsing of the libvirt-formatted files from tests/qemuxml2xmloutdata and formatting them back, and checking that they are identical. By adding this testing multiple problems in code auto-adding information was discovered. Peter Krempa (7): virDomainDefMaybeAddVirtioSerialController: Reformat hard to read linebreaks conf: domain: Insert auto-added controllers in same order as in XML parser virDomainAssignControllerIndexes: Ensure controller ordering after assigning indexes qemu: Move 'shmem' device size validation to qemu_validate qemuDomainAssignPCIAddresses: Assign extension addresses when auto-assigning PCI address virDomainDefAddConsoleCompat: Fix numbering of console targets after modification qemuxml2conftest: Test re-parsing of formatted XML src/conf/domain_conf.c | 26 ++++++++++--- src/conf/domain_postparse.c | 21 ++++++++++ src/qemu/qemu_command.c | 19 ---------- src/qemu/qemu_domain_address.c | 14 +++++-- src/qemu/qemu_validate.c | 9 +++++ .../autoindex.x86_64-latest.args | 4 +- .../channel-virtio-default.x86_64-latest.args | 2 +- .../channel-virtio-unix.x86_64-latest.args | 2 +- .../chardev-reconnect.x86_64-latest.args | 2 +- .../pci-autoadd-idx.x86_64-latest.args | 16 ++++---- .../pseries-many-buses-2.ppc64-latest.args | 4 +- .../shmem-invalid-size.x86_64-latest.err | 2 +- .../shmem-small-size.x86_64-latest.err | 2 +- .../aarch64-virt-graphics.aarch64-latest.xml | 6 +-- .../aarch64-virt-headless.aarch64-latest.xml | 6 +-- .../aarch64-virt-virtio.aarch64-4.2.0.xml | 6 +-- .../aarch64-virt-virtio.aarch64-latest.xml | 6 +-- ...rch64-virtio-pci-default.aarch64-4.2.0.xml | 6 +-- ...ch64-virtio-pci-default.aarch64-latest.xml | 6 +-- ...io-pci-manual-addresses.aarch64-latest.xml | 6 +-- .../arm-virt-virtio.aarch64-latest.xml | 6 +-- .../autoindex.x86_64-latest.xml | 12 +++--- .../channel-virtio-auto.x86_64-latest.xml | 2 +- .../channel-virtio-autoadd.x86_64-latest.xml | 2 +- .../channel-virtio-default.x86_64-latest.xml | 6 +-- .../channel-virtio-unix.x86_64-latest.xml | 6 +-- .../chardev-reconnect.x86_64-latest.xml | 6 +-- .../console-compat2.x86_64-latest.xml | 2 +- .../cpu-host-model-kvm.x86_64-4.2.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-5.0.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-5.1.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-5.2.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-6.0.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-6.1.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-6.2.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-7.0.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-7.1.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-7.2.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-8.0.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-8.1.0.xml | 12 +++--- .../cpu-host-model-kvm.x86_64-latest.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-4.2.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-5.0.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-5.1.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-5.2.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-6.0.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-6.1.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-6.2.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-7.0.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-7.1.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-7.2.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-8.0.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-8.1.0.xml | 12 +++--- .../cpu-host-model-tcg.x86_64-latest.xml | 12 +++--- .../disk-floppy-q35.x86_64-latest.xml | 8 ++-- ...dev-scsi-autogen-address.x86_64-latest.xml | 6 +-- ...tdev-vfio-zpci-boundaries.s390x-latest.xml | 4 +- ...f-aarch64-virt-headless.aarch64-latest.xml | 6 +-- .../hvf-x86_64-q35-headless.x86_64-latest.xml | 6 +-- ...ach-virt-console-virtio.aarch64-latest.xml | 6 +-- .../net-isolated-port.x86_64-latest.xml | 12 +++--- .../pci-autoadd-idx.x86_64-latest.xml | 22 +++++------ .../pcie-expander-bus.x86_64-latest.xml | 10 ++--- .../pcie-root.x86_64-latest.xml | 12 +++--- ...cie-switch-upstream-port.x86_64-latest.xml | 10 ++--- .../pcihole64-q35.x86_64-latest.xml | 12 +++--- .../pseries-many-buses-2.ppc64-latest.xml | 6 +-- ...eries-phb-default-missing.ppc64-latest.xml | 8 ++-- .../qemuxml2xmloutdata/q35.x86_64-latest.xml | 12 +++--- .../riscv64-virt-graphics.riscv64-latest.xml | 6 +-- .../riscv64-virt-headless.riscv64-latest.xml | 6 +-- .../shmem-invalid-size.x86_64-latest.xml | 34 ----------------- .../shmem-small-size.x86_64-latest.xml | 34 ----------------- .../user-aliases2.x86_64-latest.xml | 8 ++-- .../watchdog-q35-multiple.x86_64-latest.xml | 12 +++--- .../x86_64-q35-graphics.x86_64-latest.xml | 6 +-- .../x86_64-q35-headless.x86_64-latest.xml | 6 +-- tests/qemuxmlconftest.c | 38 ++++++++++++++++++- 78 files changed, 405 insertions(+), 404 deletions(-) delete mode 100644 tests/qemuxml2xmloutdata/shmem-invalid-size.x86_64-latest.xml delete mode 100644 tests/qemuxml2xmloutdata/shmem-small-size.x86_64-latest.xml -- 2.43.0 _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
