[PATCH v4 05/19] vz: change type to void vzDomainDefAddDefaultInputDevices()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



vzDomainDefAddDefaultInputDevices() returns nothing except 0. Changing return
type to void.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Frolov <frolov@xxxxxxxxx>
---
 src/vz/vz_driver.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 56b630bac0..1b31f7a7c3 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -210,14 +210,14 @@ vzConnectGetCapabilities(virConnectPtr conn)
     return virCapabilitiesFormatXML(privconn->driver->caps);
 }
 
-static int
+static void
 vzDomainDefAddDefaultInputDevices(virDomainDef *def)
 {
     int bus = IS_CT(def) ? VIR_DOMAIN_INPUT_BUS_PARALLELS :
                            VIR_DOMAIN_INPUT_BUS_PS2;
 
     if (def->ngraphics == 0)
-        return 0;
+        return;
 
     virDomainDefMaybeAddInput(def,
                               VIR_DOMAIN_INPUT_TYPE_MOUSE,
@@ -226,7 +226,6 @@ vzDomainDefAddDefaultInputDevices(virDomainDef *def)
     virDomainDefMaybeAddInput(def,
                               VIR_DOMAIN_INPUT_TYPE_KBD,
                               bus);
-    return 0;
 }
 
 static int
@@ -241,8 +240,7 @@ vzDomainDefPostParse(virDomainDef *def,
                                         def->virtType))
         return -1;
 
-    if (vzDomainDefAddDefaultInputDevices(def) < 0)
-        return -1;
+    vzDomainDefAddDefaultInputDevices(def);
 
     return 0;
 }
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux