[PATCH v4 03/19] libxl: change type to void xenDomainDefAddImplicitInputDevice()

[Dmitry Frolov <frolov@xxxxxxxxx>]

xenDomainDefAddImplicitInputDevice() returns nothing except 0. Changing return
type to void.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Frolov <frolov@xxxxxxxxx>
---
 src/libxl/libxl_domain.c | 3 +--
 src/libxl/xen_common.c   | 4 +---
 src/libxl/xen_common.h   | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 670fd2881e..cd24eb58d6 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -266,8 +266,7 @@ libxlDomainDefPostParse(virDomainDef *def,
     }
 
     /* add implicit input devices */
-    if (xenDomainDefAddImplicitInputDevice(def) < 0)
-        return -1;
+    xenDomainDefAddImplicitInputDevice(def);
 
     /* For x86_64 HVM */
     if (def->os.type == VIR_DOMAIN_OSTYPE_HVM &&
diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c
index edb20127ab..ba2a322016 100644
--- a/src/libxl/xen_common.c
+++ b/src/libxl/xen_common.c
@@ -2385,7 +2385,7 @@ xenFormatConfigCommon(virConf *conf,
 }
 
 
-int
+void
 xenDomainDefAddImplicitInputDevice(virDomainDef *def)
 {
     virDomainInputBus implicitInputBus = VIR_DOMAIN_INPUT_BUS_XEN;
@@ -2400,6 +2400,4 @@ xenDomainDefAddImplicitInputDevice(virDomainDef *def)
     virDomainDefMaybeAddInput(def,
                               VIR_DOMAIN_INPUT_TYPE_KBD,
                               implicitInputBus);
-
-    return 0;
 }
diff --git a/src/libxl/xen_common.h b/src/libxl/xen_common.h
index b21046e959..86c2c337c1 100644
--- a/src/libxl/xen_common.h
+++ b/src/libxl/xen_common.h
@@ -66,4 +66,4 @@ int xenFormatConfigCommon(virConf *conf,
 
 char *xenMakeIPList(virNetDevIPInfo *guestIP);
 
-int xenDomainDefAddImplicitInputDevice(virDomainDef *def);
+void xenDomainDefAddImplicitInputDevice(virDomainDef *def);
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx