On Mon, Jan 08, 2024 at 20:26:01 +0100, Andrea Bolognani wrote: > For machines that don't expose useful information through sysfs, > the dummy ID 0 is used. I'm not a fan, as you won't be able to use the capabilities XML to figure out whether it's supported or not, but it's the same case with 'die_id' which we approach exactly the same. Also there's no docs about those fields either in the capability XML docs. > > https://issues.redhat.com/browse/RHEL-7043 > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > src/conf/capabilities.c | 5 +- > src/conf/capabilities.h | 1 + > src/conf/schemas/capability.rng | 3 + > src/libvirt_linux.syms | 1 + > src/util/virhostcpu.c | 22 + > src/util/virhostcpu.h | 1 + > tests/capabilityschemadata/caps-qemu-kvm.xml | 32 +- > .../vircaps-aarch64-basic-clusters.xml | 448 +++++++++--------- > .../vircaps2xmldata/vircaps-aarch64-basic.xml | 32 +- > .../vircaps-x86_64-basic-dies.xml | 24 +- > .../vircaps2xmldata/vircaps-x86_64-basic.xml | 32 +- > .../vircaps2xmldata/vircaps-x86_64-caches.xml | 16 +- > tests/vircaps2xmldata/vircaps-x86_64-hmat.xml | 48 +- > .../vircaps-x86_64-resctrl-cdp.xml | 24 +- > .../vircaps-x86_64-resctrl-cmt.xml | 24 +- > .../vircaps-x86_64-resctrl-fake-feature.xml | 24 +- > .../vircaps-x86_64-resctrl-skx-twocaches.xml | 2 +- > .../vircaps-x86_64-resctrl-skx.xml | 2 +- > .../vircaps-x86_64-resctrl.xml | 24 +- > 19 files changed, 398 insertions(+), 367 deletions(-) Based on the fact that this follows what we allowed for 'die_id' I can't really reasonably request the docs, but I'd really welcome if we had some. Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
