On Tue, Jan 09, 2024 at 03:28:44PM +0100, Michal Privoznik wrote:
> In v9.7.0-rc1~130 I've shortened the path that's generated for
> <channel/> source. With that, I had to adjust regex that matches
> all versions of paths we have ever generated so that we can drop
> them (see comment around qemuDomainChrDefDropDefaultPath()). But
> as it is usually the case with regexes - they are write only.
Sounds like a skill issue to be honest :P
> And
> while I attempted to make one portion of the path optional
> ("/target/") I accidentally made regex accept more, which
> resulted in libvirt dropping the user provided path and
> generating our own instead.
>
> Fixes: d3759d3674ab9453e5fb5a27ab6c28b8ff8d5569
> Resolves: https://issues.redhat.com/browse/RHEL-20807
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> src/qemu/qemu_domain.c | 2 +-
> ...hannel-unix-source-path.x86_64-latest.args | 8 ++++++++
> .../channel-unix-source-path.xml | 16 +++++++++++++++
> ...-unix-source-path-active.x86_64-latest.xml | 20 +++++++++++++++++++
> ...nix-source-path-inactive.x86_64-latest.xml | 20 +++++++++++++++++++
> 5 files changed, 65 insertions(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
