Re: Re: [PATCH 1/3] ci: Fix upstream-qemu job definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 08, 2024 at 09:07:33PM +0100, Peter Krempa wrote:
> On Mon, Jan 08, 2024 at 11:43:22 +0100, Andrea Bolognani wrote:
> > These are jobs are supposed to be running tests using a QEMU
> > binary built from the latest upstream sources, but right now
> > they're just doing the same thing as the other jobs for the
> > target. Use the correct job templates.
> >
> > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> > ---
> >  ci/integration.yml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Looks reasonable, but IMO the CI stuff got out of hand complexity wise,
> so I'm not as confident in my review as usually.

Yeah, I'm not too confident myself, and unlike regular CI jobs I
thought there was no way to test changes to the integration part
before pushing. I see now that the LIBVIRT_CI_INTEGRATION variable
exists though, so I'll give that a try and see whether I can get a
successful run out of it before pushing.

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux