Re: [PATCH] libvirt.spec: Fix nbdkit selection logic on mingw and old rhel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 05, 2024 at 10:57:46AM +0100, Peter Krempa wrote:
> rhel-8 lacks 'pidfd_open()' support and thus nbdkit can't be enabled
> there.
>
> mingw builds explicitly disable nbdkit support, but use
> '--auto-features=enabled' thus omitting setting of
> 'nbdkit_config_default' results in meson thinking we want to enable it:
>
>   ../meson.build:1018:2: ERROR: Problem encountered: nbdkit_config_default requires nbdkit to be enabled
>
> Disable it explicitly. The meson logic might need to be fixed eventually
> when switching it on by default.
>
> Fixes: 9eabf14afbd429af1be195723fdeab5ccdd0b2cd
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  libvirt.spec.in | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

Thanks a lot for taking care of this!

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux