Re: [PATCH 1/7] cpu: : virCPUx86DataAddItem() to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 1/4/24 01:16, Artem Chernyshev wrote:
> 
> It doesn't really fix anything. The code is not broken.
> 
> 

True, just mentioned commit which I addressed in my patch

> 
> No. This changes semantics. Prior to your change, if
> qemuMonitorJSONParseCPUx86FeatureWord() failed then 'return NULL' path
> would be taken. After your change the failure is ignored and ...
> 
> 
> ... this return path is taken.
> 
> Michal

Yes, my mistake. Should I send v2 or you already fix that?

Thank you,
Artem
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux