Re: [PATCH 2/7] rpc: virnetserver: virNetServerAddService() to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/4/24 01:16, Artem Chernyshev wrote:
> virNetServerAddService() return value
> is invariant, so change it type and remove all dependent
> checks.
> 
> Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N")
> 
> Signed-off-by: Artem Chernyshev <artem.chernyshev@xxxxxxxxxxx>
> ---
>  src/lxc/lxc_controller.c |  3 +--
>  src/rpc/virnetserver.c   | 25 +++++--------------------
>  src/rpc/virnetserver.h   |  2 +-
>  tests/virnetdaemontest.c |  6 ++----
>  4 files changed, 9 insertions(+), 27 deletions(-)

> diff --git a/src/rpc/virnetserver.h b/src/rpc/virnetserver.h
> index 9f0cf3a3fc..dc60e2c2b2 100644
> --- a/src/rpc/virnetserver.h
> +++ b/src/rpc/virnetserver.h
> @@ -59,7 +59,7 @@ void virNetServerShutdownWait(virNetServer *srv);
>  
>  virJSONValue *virNetServerPreExecRestart(virNetServer *srv);
>  
> -int virNetServerAddService(virNetServer *srv,
> +void virNetServerAddService(virNetServer *srv,
>                             virNetServerService *svc);

Indentation. Here and in other patches too.

>  int virNetServerAddServiceTCP(virNetServer *srv,
>                                virSystemdActivation *act,

Michal
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux