Re: [PATCH 0/7] Code cleanup 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/4/24 01:16, Artem Chernyshev wrote:
> Several functions was modified to become invariant. Change
> their type to void and remove unnecessary checks of their
> return values.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Artem Chernyshev (7):
>   cpu: : virCPUx86DataAddItem() to void
>   rpc: virnetserver: virNetServerAddService() to void
>   lxc: virLXCControllerAddConsole() to void
>   conf: virDomainNetUpdate() to void
>   virprocess: virProcessGetNamespaces() to void
>   node_device: udevTranslatePCIIds() to void
>   node_device: udevGetStringSysfsAttr() to void
> 
>  src/conf/domain_conf.c             |   3 +-
>  src/conf/domain_conf.h             |   2 +-
>  src/cpu/cpu_x86.c                  | 179 +++++++++++------------------
>  src/cpu/cpu_x86.h                  |   4 +-
>  src/libvirt-lxc.c                  |   5 +-
>  src/libxl/libxl_capabilities.c     |  13 +--
>  src/lxc/lxc_controller.c           |   9 +-
>  src/lxc/lxc_driver.c               |   6 +-
>  src/node_device/node_device_udev.c |  69 ++++-------
>  src/qemu/qemu_capabilities.c       |   3 +-
>  src/qemu/qemu_driver.c             |   3 +-
>  src/qemu/qemu_monitor_json.c       |   7 +-
>  src/qemu/qemu_process.c            |   3 +-
>  src/rpc/virnetserver.c             |  25 +---
>  src/rpc/virnetserver.h             |   2 +-
>  src/util/virprocess.c              |   4 +-
>  src/util/virprocess.h              |   2 +-
>  tests/virnetdaemontest.c           |   6 +-
>  18 files changed, 118 insertions(+), 227 deletions(-)
> 

Fixed small nits I've raised during review and pushed.

Congratulations on your first libvirt contribution!

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux