On Wed, Jan 03, 2024 at 12:31:53 +0100, Peter Krempa wrote:
> On Wed, Jan 03, 2024 at 10:52:11 +0100, Michal Prívozník wrote:
> > On 1/3/24 10:20, Peter Krempa wrote:
> > > On Fri, Dec 15, 2023 at 13:33:10 +0100, Peter Krempa wrote:
> > >> This patch saga aims to improve and simplify testing of qemu XML
> > >> configs.
[...]
> > > Ping? I have part 2 ready already ;)
> > > _______________________________________________
> > > Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
> > > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
> >
> > Looks good. But I'm still getting some unused files:
> >
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-cdrom-network-nbdkit.xml
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-http-nbdkit.xml
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-source-curl-nbdkit-backing.xml
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-source-curl-nbdkit.xml
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-ssh-key.xml
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-ssh-nbdkit.xml
> > unused input file: .../libvirt.git/tests/qemuxml2argvdata/disk-network-ssh-password.xml
>
> Interesting, all of them pass on my box so we have a
> environment-dependant test instability here. I'm guessing it's due to
> the compile time check of nbdkit-backend support. I'll skip the last
> patch for now and address that one separately.
Yup:
# if WITH_NBDKIT
# define DO_TEST_CAPS_LATEST_NBDKIT(name, ...) \
DO_TEST_CAPS_ARCH_LATEST_FULL(name, "x86_64", ARG_NBDKIT_CAPS, __VA_ARGS__, QEMU_NBDKIT_CAPS_LAST, ARG_END)
# else
# define DO_TEST_CAPS_LATEST_NBDKIT(name, ...)
# endif /* WITH_NBDKIT */
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
