Re: [PATCH] storage_util: Fix the false condition in virStorageBackendDeviceIsEmpty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2023, Han Han wrote:
In virStorageBackendDeviceIsEmpty, the return value for
virStorageBackendPARTEDValidLabel is -1 or 0. That makes the later
condition 'ret == -2' make always false. Remove the always false
condition.

Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.

Fixes: https://gitlab.com/libvirt/libvirt/-/issues/576


As Michal pointed out in the linked issue, the functions return -2 if
the functionality was not compiled in.

Jano

Signed-off-by: Han Han <hhan@xxxxxxxxxx>
---
src/storage/storage_util.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux