On a Thursday in 2023, Michal Prívozník wrote:
On 12/21/23 09:33, Han Han wrote:Change to the boolean option "unix=on" Signed-off-by: Han Han <hhan@xxxxxxxxxx> ---And just for next time: please do insert a link to corresponding gitlab issue. For instance: Change the boolean option "unix=on". Resolves: https://gitlab.com/libvirt/libvirt/-/issues/573 Signed-off-by: .... This has two advantages: 1) We know there is an issue associated (and perhaps can find more info, though in this case it's pretty obvious),
I was not aware there was an issue filed for this, otherwise I would have included the link.
2) gitlab SHOULD close the issue automatically once the commit is merged, though this feature it broken for some time: https://gitlab.com/gitlab-org/gitlab/-/issues/389801
'Fixes:' works for auto-closing. If you don't want to mislead the reader and instead want to close the issue with a commit that does not necessarily fix the issue, 'Closes:' also works. Jano
Happy hacking! Michal _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
