On 04/23/2010 09:02 PM, Stefan Berger wrote: > This patch adds support for the RARP protocol. This may be needed due to > qemu sending out a RARP packet (at least that's what it seems to want to > do even though the protocol id is wrong) when migration finishes and > we'd need a rule to let the packets pass. > > Unfortunately my installation of ebtables does not understand -p RARP > and also seems to otherwise depend on strings in /etc/ethertype > translated to protocol identifiers. Therefore I need to pass -p 0x8035 > for RARP. To generally get rid of the dependency of that file I switch > all so far supported protocols to use their protocol identifier in the > -p parameter rather than the string. Sounds nice. > <optional> > <zeroOrMore> > + <element name="rarp"> > + <ref name="match-attribute"/> > + <ref name="common-l2-attributes"/> > + <ref name="arp-attributes"/> <!-- same as arp --> > + </element> > + </zeroOrMore> > + </optional> XML looks okay. And the refactoring into using an index looked good. ACK. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list