Re: [PATCH 0/2] qemuxml2argvtest: Don't exec '/usr/libexec/qemu/vhost-user/test-vhost-user-gpu'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/18/23 12:02, Peter Krempa wrote:
> 'qemuExtVhostUserGPUPrepareDomain' breaks our design assumptions about
> the 'PrepareDomain' step which should not touch anything on the host.
> 
> This patchset for now fixes the symptom by mocking the function and
> poisons virFork and virCommandRun so that this doesn't happen in the
> future.
> 
> Proper fix will require splitting the vhost-user GPU prepare step to
> prepare the host-specific portion separately.
> 
> Peter Krempa (2):
>   qemuxml2argvmock: Mock qemuExtVhostUserGPUPrepareDomain
>   qemuxml2argvmock: Poison virCommandRun and virFork from test context
> 
>  src/qemu/qemu_vhost_user_gpu.c |  4 ++++
>  src/qemu/qemu_vhost_user_gpu.h |  2 +-
>  src/util/vircommand.h          |  4 ++--
>  tests/qemuxml2argvmock.c       | 28 ++++++++++++++++++++++++++++
>  4 files changed, 35 insertions(+), 3 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux