Re: [PATCH v2 00/14] Unreacheble code cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/14/23 8:50 AM, Dmitry Frolov wrote:
A lot of unreacheble code was caused by int functions, which return nothing
except zero. Unreacheble code was removed. Corresponding functions type was
changed to void.

Dmitry Frolov (14):
   cpu: turn virCPUx86DataAddItem() to void
   cpu: turn virCPUx86DataAdd() to void
   libxl: turn libxlCapsAddCPUID() to void
   libxl: turn virCapabilitiesAddHostFeature() to void
   libxl: turn libxl_get_physinfo() to void
   conf: turn virCapabilitiesSetNetPrefix() to void
   libxl: turn libxlMakeDomainOSCaps() to void
   libxl: turn libxlMakeDomainDeviceDiskCaps() to void
   libxl: turn libxlMakeDomainDeviceGraphicsCaps() to void
   libxl: turn libxlMakeDomainDeviceVideoCaps() to void
   conf: turn virDomainGraphicsListenAppendAddress() to void
   vbox: turn vboxDumpDisplay() to void
   libxl: turn xenParseXLNamespaceData() to void
   rpc: turn virNetClientAddProgram() to void

  src/admin/admin_remote.c        |  3 +-
  src/conf/capabilities.c         |  8 +--
  src/conf/capabilities.h         |  4 +-
  src/conf/domain_conf.c          |  4 +-
  src/conf/domain_conf.h          |  2 +-
  src/cpu/cpu_x86.c               | 91 ++++++++++++---------------------
  src/cpu/cpu_x86.h               |  2 +-
  src/libxl/libxl_capabilities.c  | 54 +++++++------------
  src/libxl/libxl_conf.c          | 20 ++------
  src/libxl/libxl_driver.c        |  6 +--
  src/libxl/xen_common.c          |  7 +--
  src/libxl/xen_xl.c              |  8 ++-
  src/locking/lock_driver_lockd.c |  3 +-
  src/logging/log_manager.c       |  3 +-
  src/lxc/lxc_monitor.c           |  4 +-
  src/remote/remote_driver.c      |  7 ++-
  src/rpc/virnetclient.c          |  3 +-
  src/rpc/virnetclient.h          |  2 +-
  src/test/test_driver.c          |  6 +--
  src/vbox/vbox_common.c          | 13 ++---
  src/vmx/vmx.c                   |  3 +-
  tests/libxlmock.c               |  5 +-
  22 files changed, 86 insertions(+), 172 deletions(-)


A couple minor comments sent separately

Reviewed-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux