Re: [PATCH v2 13/14] libxl: turn xenParseXLNamespaceData() to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/14/23 8:51 AM, Dmitry Frolov wrote:
xenParseXLNamespaceData() always returns 0.

Signed-off-by: Dmitry Frolov <frolov@xxxxxxxxx>
---
  src/libxl/xen_xl.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c
index 553aa77896..78a3e1d519 100644
--- a/src/libxl/xen_xl.c
+++ b/src/libxl/xen_xl.c
@@ -1017,7 +1017,7 @@ xenParseXLChannel(virConf *conf, virDomainDef *def)
      return -1;
  }
-static int
+static void
  xenParseXLNamespaceData(virConf *conf, virDomainDef *def)
  {
      virConfValue *list = virConfGetValue(conf, "device_model_args");

You changed the return type to void, but you didn't actually remove the 'return' statements from the function.


@@ -1104,8 +1104,7 @@ xenParseXL(virConf *conf,
      if (xenParseXLChannel(conf, def) < 0)
          return NULL;
- if (xenParseXLNamespaceData(conf, def) < 0)
-        return NULL;
+    xenParseXLNamespaceData(conf, def);
if (virDomainDefPostParse(def, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE,
                                xmlopt, NULL) < 0)
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux