On Fri, Dec 08, 2023 at 13:32:31 -0500, Laine Stump wrote:
> On 11/27/23 9:41 AM, Peter Krempa wrote:
> > On Mon, Nov 06, 2023 at 02:38:48 -0500, Laine Stump wrote:
> > > Currently this enum is defined in domain_conf.h and named
> > > virDomainHostdevSubsysPCIDriverType. I want to use it in parts of the
> > > network and networkport config, so am moving its definition to
> > > device_conf.h which is / can be included by all interested parties,
> > > and renaming it to be less specific to its old usage (all the other
> > > parts still apply, at least functionally, to the new usage). The name
> > > change (which includes enum values) does cause a lot of churn, but
> > > it's all mechanical.
> > >
> > > Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> > > ---
> >
> > [...]
> >
> >
> > > @@ -23342,8 +23335,9 @@ virDomainHostdevDefFormatSubsysPCI(virBuffer *buf,
> > > virBufferAsprintf(&sourceAttrBuf, " writeFiltering='%s'",
> > > virTristateBoolTypeToString(def->writeFiltering));
> > > - if (pcisrc->backend != VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
> > > - const char *backend = virDomainHostdevSubsysPCIBackendTypeToString(pcisrc->backend);
> > > + if (pcisrc->backend != VIR_DEVICE_HOSTDEV_PCI_DRIVER_TYPE_DEFAULT) {
> > > + const char *backend
> > > + = virDeviceHostdevPCIDriverTypeToString(pcisrc->backend);
> >
> > Please no pointless linebreaks. The times of max 80 colums are gone.
>
> But what about this onion on my belt?
>
> Old habits die hard, but I'll fix all of these. Are you okay with the
> currently listed 100 character limit? Or do you think there should be *no*
> line length limit?
Having a specific number leads to stuff like this. I'd prefer we stay at
just stating that lines should be reasonably long without breaking
coding style while maintaining readability. Once the line gets
ridiculously long it's usually obvious to many that it's not a good
idea.
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
