Re: [libvirt PATCH 1/1] rpcgen: Skip generator tests on macOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 30, 2023 at 08:29:55PM +0100, Andrea Bolognani wrote:
> The generator can produce different code on Linux and macOS:
> specifically, on the former we want to use xdr_uint64_t while
> the latter needs xdr_u_int64_t instead.
> 
> This is clearly a problem for tests that involve comparing the
> output produced against some expected output that's stored in
> the git repository.
> 
> In the long run, we need to find a better way to handle this,
> but since 9.10.0 is going to be released very soon and we don't
> want it to have a broken test suite on macOS, simply skip the
> generator tests on that platform for now.
> 
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  scripts/rpcgen/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux