On Thu, Nov 30, 2023 at 10:27:34AM -0500, Andrea Bolognani wrote: > > > > > As a short-term solution, it's fine :) > > > > > > > > Never mind, this very obviously doesn't pass muster: > > > > > > > > E AssertionError: assert '\nvoid xdr_T...rn TRUE;\n}\n' == > > > > '\nvoid xdr_T...rn TRUE;\n}\n' > > > > E Skipping 9072 identical leading characters in diff, use -v to show > > > > E - if (!xdr_uint64_t(xdrs, &objp->suh)) > > > > E + if (!xdr_u_int64_t(xdrs, &objp->suh)) > > > > E ? + > > > > E return FALSE; > > > > E if (!xdr_bool(xdrs, &objp->sb)) > > > > E return FALSE;... > > > > E > > > > E ...Full output truncated (90 lines hidden), use '-vv' to show > > > > > > > > My test setup was a bit wonky so I initially failed to catch it. > > > > Apologies for the noise. In the interest of getting 9.10.0 out of the door according to the original schedule, with reasonable test coverage and no broken test suite on macOS, please consider: https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/thread/R4YI4JZVWZGP6G2XZTG3SC3FEW7O3TH2/ If that patch is acceptable to you, you can retain my ACK to this patch of yours and push it. I'll push my patches tomorrow. -- Andrea Bolognani / Red Hat / Virtualization _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
