On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote: > On Thu, Nov 30, 2023 at 02:07:55PM +0000, Daniel P. Berrangé wrote: > > +++ b/scripts/rpcgen/tests/test_demo.c > > @@ -3,6 +3,10 @@ > > #include <rpc/xdr.h> > > #include <stdbool.h> > > > > +#ifdef __APPLE__ > > +# define xdr_uint64_t xdr_u_int64_t > > +#endif > > For the long run, I think it would make more sense to have this > workaround as part of the generator's output, so that using > VIR_TEST_REGENERATE_OUTPUT will produce the same results regardless > of whether it's run on Linux or macOS. It would also avoid the need > to add a similar workaround somewhere in the library code the day we > start needing uint64_t anywhere in our RPC protocol. Long term my intention was to stop using libxdr entirely, and instead add APIS to virNetMessage to let us serialize/deserialize XDR with a less insane API :) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
