On Thu, Nov 30, 2023 at 09:24:45AM +0000, Daniel P. Berrangé wrote: > On Wed, Nov 29, 2023 at 06:18:27PM +0100, Andrea Bolognani wrote: > > Right now we don't have pytest installed in any of the CI build > > environments, and tests are only executed when pytest is present, so > > the test coverage is exactly zero. > > > > This series changes things so that we actually run the test suite as > > part of the CI pipeline, which immediately triggers a build failure > > on macOS: > > > > In file included from ../scripts/rpcgen/tests/test_demo.c:7: > > ../scripts/rpcgen/tests/demo.c:402:10: error: call to undeclared function 'xdr_uint64_t'; ISO C99 and later > > do not support implicit function declarations [-Wimplicit-function-declaration] > > if (!xdr_uint64_t(xdrs, &objp->suh)) > > ^ > > ../scripts/rpcgen/tests/test_demo.c:25:29: error: too few arguments to function call, expected 3, have 2 > > ret = !!proc(&xdr, vorig); > > ~~~~ ^ > > ../scripts/rpcgen/tests/test_demo.c:52:28: error: too few arguments to function call, expected 3, have 2 > > ret = !!proc(&xdr, vnew); > > ~~~~ ^ > > ../scripts/rpcgen/tests/test_demo.c:66:28: error: too few arguments to function call, expected 3, have 2 > > ret = !!proc(&xdr, vnew); > > ~~~~ ^ > > 4 errors generated. > > > > I haven't looked into that failure at all, but it looks like > > something that we might want to fix before 9.10.0 is released? > > libvirt itself seems to build fine, so perhaps it's just the test > > suite that needs fixing. I leave the call to people who are more > > familiar with the rpcgen situation. > > I've just CC'd you on a possible patch. Could you test it with this > series applied to verify the test suite passes. Replied there. Fix for the "too few arguments" error: https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/thread/23XMES2PIVIUTW44P7FHZYAYVOUDSE42/ -- Andrea Bolognani / Red Hat / Virtualization _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
