Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 30, 2023 at 10:06:38AM +0100, Peter Krempa wrote:
> On Thu, Nov 30, 2023 at 09:49:56 +0100, Martin Kletzander wrote:
> > On Wed, Nov 29, 2023 at 06:33:54PM +0000, Richard W.M. Jones wrote:
> > > 
> > > Can we have the error message include a link to this page?
> > > https://wiki.libvirt.org/Failed_to_connect_to_the_hypervisor.html
> > > 
> > 
> > I think we could, although I'd be a bit afraid of the precedence which,
> > by itself is not that bad, but keeping the separate document(s) up to
> > date could bite us in the back in a while.  I won't go against the idea
> > if others in this discussion are fine with it and we reach a consensus.
> 
> There is one precedent case, when backing image brobing fails due to
> mess-up in the format fields, in which case the error links to an
> article in the kbase on proper setup of images.
> 
> I suggest that if you want to add a link into the error, the article
> should be kept in the kbase in the main repo instead of the wiki.
> 
> The article should probably be also clarified to contain only this case
> and also link perhaps to the page about how to setup daemons to run.

This is a lot of extra work just to fix a bad error message.

Error messages should **always** be actionable.  They should, every
single time, tell the user in simple language: What is wrong.  How to
fix it.

This is an egregious example of a bad error from libvirt that I see
happening over and over again.  Let's just fix it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux