On 11/29/23 18:18, Andrea Bolognani wrote: > Right now we don't have pytest installed in any of the CI build > environments, and tests are only executed when pytest is present, so > the test coverage is exactly zero. > > This series changes things so that we actually run the test suite as > part of the CI pipeline, which immediately triggers a build failure > on macOS: > > In file included from ../scripts/rpcgen/tests/test_demo.c:7: > ../scripts/rpcgen/tests/demo.c:402:10: error: call to undeclared function 'xdr_uint64_t'; ISO C99 and later > do not support implicit function declarations [-Wimplicit-function-declaration] > if (!xdr_uint64_t(xdrs, &objp->suh)) > ^ > ../scripts/rpcgen/tests/test_demo.c:25:29: error: too few arguments to function call, expected 3, have 2 > ret = !!proc(&xdr, vorig); > ~~~~ ^ > ../scripts/rpcgen/tests/test_demo.c:52:28: error: too few arguments to function call, expected 3, have 2 > ret = !!proc(&xdr, vnew); > ~~~~ ^ > ../scripts/rpcgen/tests/test_demo.c:66:28: error: too few arguments to function call, expected 3, have 2 > ret = !!proc(&xdr, vnew); > ~~~~ ^ > 4 errors generated. I suspect this is because on macos there's a different rpc library from libtirpc which compiles just fine. > > I haven't looked into that failure at all, but it looks like > something that we might want to fix before 9.10.0 is released? > libvirt itself seems to build fine, so perhaps it's just the test > suite that needs fixing. I leave the call to people who are more > familiar with the rpcgen situation. > > Andrea Bolognani (5): > rpcgen: Don't skip all tests when pytest is missing > rpcgen: Organize meson tests into suites > rpcgen: Skip tests if tests are disabled > rpcgen: Reformat meson files > ci: Refresh generated files > > 91 files changed, 118 insertions(+), 30 deletions(-) > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> And safe for freeze. Michal _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
