Please change the subject/summary to:
qemu: capabilities: Introduce QEMU_CAPS_VFIO_VFTOKEN capability
On Wed, Nov 29, 2023 at 21:07:22 -0700, Vivek Kashyap wrote:
> Introduce qemu capability for vf-token
>
> Signed-off-by: Vivek Kashyap <vivek.kashyap@xxxxxxxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 3 +++
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 83119e871a..f4cacd48d0 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -698,6 +698,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
> /* 450 */
> "run-with.async-teardown", /* QEMU_CAPS_RUN_WITH_ASYNC_TEARDOWN */
> "virtio-blk-vhost-vdpa", /* QEMU_CAPS_DEVICE_VIRTIO_BLK_VHOST_VDPA */
> + "vf-token", /* QEMU_CAPS_VFIO_VFTOKEN */
> );
>
>
> @@ -1385,6 +1386,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
> { "virtio-crypto-device", QEMU_CAPS_DEVICE_VIRTIO_CRYPTO },
> { "cryptodev-backend-lkcf", QEMU_CAPS_OBJECT_CRYPTO_LKCF },
> { "pvpanic-pci", QEMU_CAPS_DEVICE_PANIC_PCI },
> + { "vf-token", QEMU_CAPS_VFIO_VFTOKEN },
> };
>
>
> @@ -1447,6 +1449,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVirtioSCSI[] = {
> };
>
> static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVfioPCI[] = {
> + { "vf-token", QEMU_CAPS_VFIO_VFTOKEN, NULL },
> };
>
> static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsSCSIDisk[] = {
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index 3c4f7f625b..f97b1c9fd5 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -677,6 +677,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
> /* 450 */
> QEMU_CAPS_RUN_WITH_ASYNC_TEARDOWN, /* asynchronous teardown -run-with async-teardown=on|off */
> QEMU_CAPS_DEVICE_VIRTIO_BLK_VHOST_VDPA, /* virtio-blk-vhost-vdpa block driver */
> + QEMU_CAPS_VFIO_VFTOKEN, /* vf-token support */
As pointed out the last time:
https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/message/KSKOCL2CQT7AU2D46LMJVPTDROOCPYJT/
after this patch the test suite fails:
224/322 libvirt:bin / qemucapabilitiestest FAIL 1.30s exit status 1
>>> MALLOC_PERTURB_=96 abs_top_srcdir=/home/pipo/libvirt abs_srcdir=/home/pipo/libvirt/tests abs_builddir=/home/pipo/build/libvirt/gcc/tests VIR_TEST_EXPENSIVE=0 LC_ALL=C LD_LIBRARY_PATH=/home/pipo/build/libvirt/gcc/src:/home/pipo/build/libvirt/gcc/tests G_DEBUG=fatal-warnings LIBVIRT_AUTOSTART=0 abs_top_builddir=/home/pipo/build/libvirt/gcc /home/pipo/build/libvirt/gcc/tests/qemucapabilitiestest
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stderr:
TEST: qemucapabilitiestest
..........................!.......!..... 40
............................!... 72 FAIL
3 tests failed. Run them using:
VIR_TEST_DEBUG=1 VIR_TEST_RANGE=27,35,69 /home/pipo/build/libvirt/gcc/tests/qemucapabilitiestest
as you didn't include the required output file updates here. I also
explicitly noted that it's required to be done so that the test suite
passes after every commit and I've also noted how to do it.
In your next post please make sure to address all feedback.
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
