On Mon, Nov 06, 2023 at 02:38:56 -0500, Laine Stump wrote: > virHostdevIsVFIODevice() and virDomainDefHasVFIOHostdev() are only ever > called from the QEMU driver, and in the case of the QEMU driver, any > PCI hostdev by definition uses VFIO, so really all these callers only > need to know if the device is a PCI hostdev. > > (It turned out that the less specific virHostdevIsPCIDevice() already > existed in hypervisor/virhostdev.c, so I had to remove one of them; > since conf is a lower level directory than hypervisor, and the > function is called from conf, keeping the copy in hypervisor would > have required moving its caller (virDomainDefHasPCIHostdev()) into > hypervisor as well, so I just removed the copy in hypervisor.) > > Signed-off-by: Laine Stump <laine@xxxxxxxxxx> > --- > src/conf/domain_conf.c | 13 ++++++------- > src/conf/domain_conf.h | 4 ++-- > src/hypervisor/virhostdev.c | 8 -------- > src/hypervisor/virhostdev.h | 2 -- > src/libvirt_private.syms | 5 ++--- > src/qemu/qemu_domain.c | 6 +++--- > src/qemu/qemu_hostdev.c | 2 +- > src/qemu/qemu_hotplug.c | 2 +- > 8 files changed, 15 insertions(+), 27 deletions(-) Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
