Re: [PATCH 0/7] storage_file_probe: Handle qcow2 images with 'protocol' driver name in 'backing file format' field (part 1 - the fix)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Friday in 2023, Peter Krempa wrote:
See 6/7 and 7/7 for the rationale. Further patches will be posted to
refactor the rest of the parsers which are bitrotten.

Peter Krempa (7):
 storage_file_probe: Remove unused state 'BACKING_STORE_ERROR'
 virStorageFileProbeGetMetadata: Do not partially skip probing of the
   image
 storage_file_probe: Remove BACKING_STORE_OK,BACKING_STORE_INVALID
   states
 virstoragetest: Use strings for storage type and format in output data
 virstoragetest: Format detected/unprocessed backing store format into
   output files
 virstoragetest: Add test cases for QCOW2 files with a protocol name as
   backing file format
 storage_file_probe: Treat qcow2 images with protocol drivers in
   backing store field as raw

src/storage_file/storage_file_probe.c         |  71 ++++++++----------
tests/virstoragetest.c                        |  19 ++++-
.../images/qcow2-protocol-backing-file.qcow2  | Bin 0 -> 196616 bytes
[...]
tests/virstoragetestdata/out/raw-raw          |   5 +-
22 files changed, 173 insertions(+), 99 deletions(-)
create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-file.qcow2
create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-nbd.qcow2
create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-file
create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-nbd


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux