On Mon, Apr 26, 2010 at 11:26:51AM -0600, Eric Blake wrote:
> On 04/26/2010 11:11 AM, Guido Günther wrote:
> > Hi,
> > this patch from Klau Ethgen looks right to me. O.k. to apply? I'll
> > remove the comment with this patch then.
>
> Is there documentation somewhere that mentions what base the udev
> strings are encoded in? At any rate, I agree with you that given the
> XXX comment, that this patch looks right.
That's my comment in the code. I was uncertain at the time I wrote it
what the correct base was. If you're certain that the correct base is
16, then ACK, and please do remove the comment.
Dave
> > if (udevGetUintSysfsAttr(device,
> > "bInterfaceNumber",
> > &data->usb_if.number,
> > - 10) == PROPERTY_ERROR) {
> > + 16) == PROPERTY_ERROR) {
>
> ACK.
>
> --
> Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
> Libvirt virtualization library http://libvirt.org
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list