Re: [PATCH 3/3] syntax-check: Forbid use of qsort()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 23, 2023 at 13:19:00 +0100, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  build-aux/syntax-check.mk | 7 +++++++
>  tools/nss/libvirt_nss.c   | 3 ++-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
> index 309ca0c29a..462bff72f8 100644
> --- a/build-aux/syntax-check.mk
> +++ b/build-aux/syntax-check.mk
> @@ -248,6 +248,13 @@ sc_prohibit_canonicalize_file_name:
>  	halt='use virFileCanonicalizePath() instead of canonicalize_file_name()' \
>  	  $(_sc_search_regexp)
>  
> +# qsort from glibc is unstable. Use g_qsort_with_data from glib instead

'qsort from glibc has unstable sort ordering for "equal" members' or
something similar so that it doesn't sound like the function can break
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux