Re: [libvirt PATCH] rpc: Pass GPG_TTY and TERM environment variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 16, 2023 at 10:38:41PM +0100, Andrea Bolognani wrote:
> gpg-agent can be used instead of ssh-agent to authenticate
> against an SSH server, but in order to do so the GPG_TTY and
> TERM environment variables need to be passed through.
> 
> For obvious reasons, we avoid doing that when no_tty=1 is found
> in the connection URI.
> 
> https://bugs.debian.org/843863
> https://gitlab.com/libvirt/libvirt/-/merge_requests/290
> 
> Thanks: Guilhem Moulin <guilhem@xxxxxxxxxxx>
> Thanks: Kunwu Chan <chentao@xxxxxxxxxx>
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  src/rpc/virnetsocket.c | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux