Re: [libvirt PATCH] src: reject empty string for 'dname' in migrate APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 08, 2023 at 16:23:57 +0000, Daniel P. Berrangé wrote:
> A domain name is expected to be non-empty, and we validate this when
> parsing XML, or accepting a new name during renames. We fail to
> enforce this property, however, when performing a migration. This
> was discovered when a user complained about inaccessible VMs after
> migrating with the Rust APIs which mistakenly hardcoded 'dname' to
> the empty string.
> 
> Fixes: https://gitlab.com/libvirt/libvirt-rust/-/issues/11
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/internal.h       | 14 +++++++
>  src/libvirt-domain.c | 97 +++++++++++++++++++++++++++++++++++++++-----
>  2 files changed, 100 insertions(+), 11 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux