Re: [libvirt PATCH] conf: virDomainDiskSourceFormat: check for srcpool presence correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 01, 2023 at 03:22:12PM +0100, Ján Tomko wrote:
> As a guard against programming errors, one part of the condition
> only dereferences srcpool if it exists, other one does not.
>
> Move the check up one level so that it actually has a chance to do
> something useful.
>
> Fixes: 19b1c0d31988a3a10c4694c10c27eb15c018f450
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux