Re: [PATCH] ci: workaround broken opensuse leap 15.5 tirpc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote:
> On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> > On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote:
> > > On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
> > > > Temporarily disable '-Wmissing-include-dirs' becuase the
> > > > libtirpc pkg-confog file has a bogus include dir. The
> > > > headers can fortunately still be found since they are
> > > > in the system include dir.
> > > >
> > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > >
> > > even though this patch does not apply for me for some reason, no idea why, it is
> > > valid and our CI fails without it, hence
> >
> > Ah, since the switch to the new ML I cannot apply any patch using git
> > am:
> >
> > warning: quoted CRLF detected
> > Applying: ci: workaround broken opensuse leap 15.5 tirpc
> > Using index info to reconstruct a base tree...
> > error: patch failed: ci/gitlab/builds.yml:332
> > error: ci/gitlab/builds.yml: patch does not apply
> > error: patch failed: ci/manifest.yml:205
> 
> Yeah, both me and Laine noticed this the other day. Patches look fine
> in mutt, but if you save them to a file they end up looking all wonky
> (see attached file for an example) and 'git am' won't like them.

Well that's strange.

The version I sent was

  Content-Type: text/plain; charset=UTF-8
  Content-Transfer-Encoding: 8bit

What you have attached is

  Content-Type: text/plain; charset="utf-8"
  Content-Transfer-Encoding: base64

Meanwhile when downloading from the archives

  Content-Type: text/plain; charset="utf-8"
  Content-Transfer-Encoding: quoted-printable

IOW, something in the mail chain is screwing around with the content.

Aside from harming git am, this is almost certainly going to doom
DKIM signatures and GPG signatures covering the content.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux