Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 03, 2023 at 10:41:51AM +0000, Daniel P. Berrangé wrote:
> On Fri, Nov 03, 2023 at 03:19:17AM -0700, Andrea Bolognani wrote:
> > On Fri, Nov 03, 2023 at 03:11:07AM -0700, Andrea Bolognani wrote:
> > > On Fri, Nov 03, 2023 at 12:00:30AM -0400, Laine Stump wrote:
> > > > [*] There may be a better way to suppress this environment setting
> > > >     (maybe something done to prevent it from ever being added to the
> > > >     environment in the first place?), and that would be fine too. This
> > > >     patch does work though.
> > >
> > > Yeah, I think this is pretty safe but it's kinda weird that this
> > > specific environment variable would make it through despite our
> > > filtering mechanisms in virCommand. So if some good soul with access
> > > to a macOS 14 installation (*cough cough* ;) could try to figure out
> > > why this started showing up all of a sudden, when it was not there
> > > for any previous version of macOS, that would be absolutely awesome.
> > 
> > Oh, and of course the same person could also look at all the various
> > 
> >   ld: warning: -undefined error is deprecated
> 
> Meson add "-undefined,error" and macOS no longer likes that:
> 
>   https://github.com/mesonbuild/meson/issues/12450
> 
> >   ld: warning: ignoring duplicate libraries: '-lxml2'
> 
> There's a similarish warning reported against homebew
> 
>   https://github.com/orgs/Homebrew/discussions/4794

Actually I think it is more mundane and a stupid warning:

% gcc c.c -lxml2

% gcc c.c -lxml2 -lxml2
ld: warning: ignoring duplicate libraries: '-lxml2'


oooooh soo many projects have the same -lXXX repeated mamy times when
building, as build systems don't make it easy to merge duplicates.
Warning about this is madness :-(

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux