Re: mingw rpm build busted? (was: Release of libvirt-9.9.0)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 01, 2023 at 10:54:25AM -0400, Cole Robinson wrote:
> On 11/1/23 5:44 AM, Jiri Denemark wrote:
> > The 9.9.0 release of both libvirt and libvirt-python is tagged and
> > signed tarballs and source RPMs are available at
> > 
> >     https://download.libvirt.org/
> >     https://download.libvirt.org/python/
> > 
> > Thanks everybody who helped with this release by sending patches,
> > reviewing, testing, or providing feedback. Your work is greatly
> > appreciated.
> > 
> > * New features
> > 
> >   * QEMU: implement reverting external snapshots
> > 
> >     Reverting external snapshots is now possible using the existing API
> >     ``virDomainSnapshotRevert()``. Management application can check host
> >     capabilities for ``<externalSnapshot/>`` element within the list of
> >     guest features to see if the current libvirt supports both deleting
> >     and reverting external snapshots.
> > 
> >   * virsh: add ``console --resume`` support
> > 
> >     The ``virsh console`` subcommand now accepts a ``--resume`` option. This
> >     will resume a paused guest after connecting to the console.
> > 
> > * Improvements
> > 
> >   * virsh: Improve ``virsh start --console`` behavior
> > 
> >     The ``virsh start --console`` now tries to connect to the guest console
> >     before starting the vCPUs.
> > 
> >   * virsh: Improve ``virsh create --console`` behavior
> > 
> >     The ``virsh create --console`` now tries to connect to the guest console
> >     before starting the vCPUs.
> > 
> 
> RPM build is busted in mingw meson step. rawhide log:
> https://kojipkgs.fedoraproject.org//work/tasks/8354/108418354/build.log
> 
> Error is:
> 
> ../meson.build:2050:4: ERROR: Problem encountered: cannot enable
> expensive tests when tests are disabled
> 
> I'm getting it on up to date f38 as well. Anyone else seeing this? meson
> 1.2.3 and 1.2.2 both affected

That will be exposed by

ommit 8ce0decc372051d616018f57ae268e2f03082eec
Author: Andrea Bolognani <abologna@xxxxxxxxxx>
Date:   Tue Oct 3 14:53:08 2023 +0200

    meson: Make -Dexpensive_tests depend on -Dtests
    
    It only makes sense to enable expensive tests when tests are
    enabled. Disallow invalid configurations.
    
    Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
    Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
    Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>


the bug is that libvirt.spec.in is passing

  -Dexpensive_tests=enabled \
  -Dtests=disabled \


to %mingw_meson which is a nonsensical combniation. Flip expensive tests
to disabled for mingw.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux