On Tue, Oct 31, 2023 at 18:12:59 +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > src/qemu/qemu_migration.c | 5 +++++ > src/qemu/qemu_migration.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index ac58aa1a8c..bf6f1de310 100644 > --- a/src/qemu/qemu_migration.c > +++ b/src/qemu/qemu_migration.c > @@ -1600,6 +1600,11 @@ qemuMigrationSrcIsSafe(virDomainDef *def, > if ((rc = virFileIsSharedFS(src)) < 0) { > return false; > } else if (rc == 0) { > + /* Ignore the outcome of this check if we've been > + * asked to assume that storage is shared */ What purpose does it serve to do the check if we're about to ignore it? Just assume it's shared right at the beginning.