Re: [libvirt PATCH 0/6] meson: Improve handling of tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 25, 2023 at 09:41:40AM +0200, Michal Prívozník wrote:
> On 10/3/23 16:56, Andrea Bolognani wrote:
> > Andrea Bolognani (6):
> >   meson: Do less when not building from git
> >   meson: Move all handling of test options together
> >   meson: Handle -Dtests=enabled with Clang
> >   meson: Make -Dexpensive_tests depend on -Dtests
> >   meson: Disable all tests when tests are disabled
> >   meson: Rename build_tests -> tests_enabled
>
> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Thanks a lot for the review!

Unfortunately I have realized that this, merged as-is, would break
things quite badly on macOS and consequently result in every single
pipeline failing. Wouldn't want that :)

Luckily the fix is not complicated and doesn't invalidate most of the
series either. v2 here:

  https://listman.redhat.com/archives/libvir-list/2023-October/242876.html

-- 
Andrea Bolognani / Red Hat / Virtualization





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux