On Mon, Oct 02, 2023 at 10:51:15AM +0200, Andrea Bolognani wrote: > This series addresses two pieces of feedback from my recent systemd > changes: that some settings, such as LimitNOFILE, where still being > repeated verbatim in multiple locations, and that only having the > foo.{service,socket}.extra.in files for some services and not others > could be confusing. > > Andrea Bolognani (11): > systemd: libvirtd doesn't need @sockprefix@ > systemd: Support merging multiple units > systemd: Accept multiple files for service_extra_in/socket_extra_in > systemd: Introduce systemd_service_limitnofile_extra > systemd: Introduce systemd_service_taskmax_extra > systemd: Introduce systemd_service_limitmemlock_extra > systemd: Introduce systemd_service_oomscoreadjust_extra > systemd: Allow comments at the top of units > systemd: Set service_extra_in/socket_extra_in everywhere > systemd: Make service_extra_in/socket_extra_in required > systemd: Tweak service definitions Ping It still applies cleanly. I've noticed that I've called one of the new meson variables systemd_service_taskmax_extra instead of systemd_service_tasksmax_extra The latter is consistent with the name of the corresponding file (src/virtd.service.tasksmax.extra.in) and the systemd knob it changes (TasksMax=). I've changed it locally, but it doesn't seem worthwhile to post a v2 just because of that. -- Andrea Bolognani / Red Hat / Virtualization