On Wed, Oct 18, 2023 at 12:38:10PM +0200, Juan Quintela wrote: > Juan Quintela <quintela@xxxxxxxxxx> wrote: > > Based on: Message-ID: <20231018100651.32674-1-quintela@xxxxxxxxxx> > > [PULL 00/11] Migration 20231018 patches > > > > And here we are, at v7: > > - drop black line at the end of deprecated.rst > > - change qemu-iotest output due to warnings for deprecation. > > > > The only real change is the output of the qemu-iotest. That is the > > reason why I maintained the reviewed-by. But will be happy if anyone > > of the block people ack the changes. > > I forgot to include the link to the CI of the previous failure. > > https://gitlab.com/juan.quintela/qemu/-/jobs/5314070229 > > tput mismatch (see /builds/juan.quintela/qemu/build/tests/qemu-iotests/scratch/raw-file-183/183.out.bad) > --- /builds/juan.quintela/qemu/tests/qemu-iotests/183.out > +++ /builds/juan.quintela/qemu/build/tests/qemu-iotests/scratch/raw-file-183/183.out.bad > @@ -28,6 +28,8 @@ > { 'execute': 'migrate', > 'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } } > +warning: parameter 'blk is deprecated; use blockdev-mirror with NBD instead > +warning: block migration is deprecated; use blockdev-mirror with NBD instead > {"return": {}} > { 'execute': 'query-status' } > {"return": {"status": "postmigrate", "singlestep": false, "running": > false}} IIUC, the JSON bits are being written on stdout, and the warnings are being written on stderr. The interleaving of the data is potentially going to be non-deterministic in the .out file. Generally you'd want a filter in the iotests that culls the warning: lines to avoid this mixing of stdout/err streams. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
