On Mon, Oct 16, 2023 at 10:07:48 +0200, Michal Privoznik wrote: > Our virBuildPath() constructs a path from given arguments. > Exactly like g_build_filename(), except the latter is more > generic as it uses backslashes on Windows. Therefore, replace the > former with the latter. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > docs/kbase/internals/command.rst | 2 +- > src/util/virfcp.c | 2 +- > src/util/virhook.c | 4 ++-- > src/util/virpci.c | 4 ++-- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/docs/kbase/internals/command.rst b/docs/kbase/internals/command.rst > index 738fb5930a..d958c9d16a 100644 > --- a/docs/kbase/internals/command.rst > +++ b/docs/kbase/internals/command.rst > @@ -444,7 +444,7 @@ src/util/hooks.c > g_autofree char *path = NULL; > g_autoptr(virCommand) cmd = NULL; > > - virBuildPath(&path, LIBVIRT_HOOK_DIR, drvstr); > + path = g_build_filename(LIBVIRT_HOOK_DIR, drvstr); It's docs, but it's missing the NULL sentinel. Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
