On a Monday in 2023, Michal Privoznik wrote:
In my recent commit of v9.8.0-rc1~7 I've introduced validation wrt other memory devices. And mostly works, except when doing memory device update ('virsh update-memory-device') because then @mem is just parsed <memory/> device XML and thus its pointer is not in the vm->def->mem, yet. Thus my algorithm which skips over the same entry fails. Fortunately, we require full device XML on device update and thus we can use device address and aliases to detect duplicity. Fixes: 3fd64fb0e236fc80ffa2cc977c0d471f11fc39bf Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- src/conf/domain_validate.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature