Re: [libvirt] [PATCH 1/3] Add dnsmasq module (v2.1)

[Jim Meyering <jim@xxxxxxxxxxxx>]

Satoru SATOH wrote:
> Ok, here is updated one. Could you please take a look at this?

Thanks.  That looks fine now.
modulo one nit:

...
> +static int
> +hostsfileWrite(const char *path,
> +               dnsmasqDhcpHost *hosts,
> +               unsigned int nhosts)
> +{
> +    char *tmp = NULL;

This is a dead store, too.

       char *tmp;

> +    FILE *f;
> +    bool istmp = true;
> +    unsigned int i;
> +    int rc = 0;
> +
> +    if (nhosts == 0)
> +        return rc;
> +
> +    if (virAsprintf(&tmp, "%s.new", path) < 0)
> +        return ENOMEM;
...

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list